Fixed documentation to work with project.toml instead of setup.py #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susuhahnml
force-pushed
the
sh/documentation-fix
branch
from
96bc234 to
0c421da
Compare
|
@susuhahnml there is no need to support python 3.7 anymore. Just remove the importlib_metadata part. To get rid of the errors just run pre-commit. |
susuhahnml
force-pushed
the
sh/documentation-fix
branch
from
0c421da to
52daf65
Compare
|
@rkaminsk SHould I also remove the case for python 3.7 in the code then? in the parser.py file |
Yes, please do this. Python 3.9 is the latest release still supported. It is not worth the headache to support earlier versions. We could even drop python 3.9 and go for 3.10 if this makes our lives easier. |
susuhahnml
force-pushed
the
sh/documentation-fix
branch
from
52daf65 to
cb5a079
Compare
rkaminsk
reviewed
Nov 13, 2024
susuhahnml
force-pushed
the
sh/documentation-fix
branch
from
cb5a079 to
155922f
Compare
|
Read to merge (I think) @rkaminsk |
just wording
rkaminsk
reviewed
Nov 14, 2024
rkaminsk
reviewed
Nov 14, 2024
rkaminsk
reviewed
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.